Skip to content

Add githubPullRequests.createInBrowser setting to open PR creation in browser#8234

Draft
Copilot wants to merge 8 commits intomainfrom
copilot/add-pr-creation-button
Draft

Add githubPullRequests.createInBrowser setting to open PR creation in browser#8234
Copilot wants to merge 8 commits intomainfrom
copilot/add-pr-creation-button

Conversation

Copy link
Contributor

Copilot AI commented Dec 9, 2025 •
edited
Loading

Add githubPullRequests.createInBrowser Setting

This PR adds a setting that changes the behavior of the existing "Create Pull Request" command to open GitHub in the browser instead of showing the create view.

Implementation

Setting (package.json):

  • Added githubPullRequests.createInBrowser boolean setting (default: false)
  • When true, the pr.create command opens GitHub in browser instead of showing the create view

Backend (src/view/reviewManager.ts):

  • Modified createPullRequest() to check the setting using CREATE_IN_BROWSER constant
  • Added openCreatePullRequestInBrowser() method that:
    • Gets current branch (or specified compareBranch)
    • Fetches pull request defaults to determine base branch
    • Constructs URL: {normalizedHost}/{owner}/{repo}/compare/{base}...{head}
    • Opens URL in browser
  • Added clarifying comment about owner vs repository name source

Constants (src/common/settingKeys.ts):

  • Added CREATE_IN_BROWSER constant

Changes

  • Add githubPullRequests.createInBrowser setting
  • Modify pr.create command to check setting and open browser when true
  • Use same base branch logic as create view
  • Use constant instead of hardcoded string
  • Add clarifying comments
  • Revert all create view related changes (UI button and related code)
  • Compile, lint, and hygiene checks pass
Original prompt

This section details on the original issue you should resolve

<issue_title>Add a button that lets me create the PR in the browser</issue_title>
<issue_description>

I don't really like the look and feel and UX of the sidebar PR form. Can you just add a button that takes me to the web site?</issue_description>

Comments on the Issue (you are @copilot in this section)

@alexr00 We've refreshed the sidebar, maybe you find it easier to use now?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add button to create PR in browser Add "Create in Browser" button to PR creation view Dec 9, 2025
Copilot AI requested a review from alexr00 December 9, 2025 11:37
alexr00
alexr00 requested changes Dec 12, 2025
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot no need to change the current create view. Just add a setting githubPullRequest.createInBrowser, which defaults to false. When set to true, the existing "create" command should open the browser with the appropriate PR URL for the current branch and correct base branch, using the same base branch logic that the "create" view does to pick the starting base branch.

Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot no need to change the current create view. Just add a setting githubPullRequest.createInBrowser, which defaults to false. When set to true, the existing "create" command should open the b...

Done in f60aad2.

I've changed the approach:

  • Removed the UI button from the create view
  • Added githubPullRequests.createInBrowser setting (defaults to false)
  • When set to true, the existing pr.create command opens the browser with the appropriate PR URL
  • Uses the same base branch logic as the create view to determine the starting base branch
  • URL format: {host}/{owner}/{repo}/compare/{base}...{head}

Copilot AI changed the title Add "Create in Browser" button to PR creation view Add githubPullRequests.createInBrowser setting to open PR creation in browser Dec 12, 2025
Copilot AI requested a review from alexr00 December 12, 2025 10:20
alexr00
alexr00 requested changes Dec 18, 2025
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot revert the create view related changes, we don't need them anymore.

Copy link
Contributor Author

Copilot AI commented Dec 18, 2025

@copilot revert the create view related changes, we don't need them anymore.

Done in d72d7ab. Reverted all create view related changes:

  • Removed openCreateInBrowser() method from createPRViewProvider.ts
  • Removed message handler for pr.openCreateInBrowser
  • Removed openCreateInBrowser() from createContextNew.ts
  • Removed "Create in Browser" button from app.tsx

The PR now only contains the setting and the logic in reviewManager.ts that checks the setting when the pr.create command is invoked.

Copilot AI requested a review from alexr00 December 18, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexr00 alexr00 Awaiting requested review from alexr00

Requested changes must be addressed to merge this pull request.

Assignees

@alexr00 alexr00

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a button that lets me create the PR in the browser

2 participants

@alexr00